Skip to content

K8s: code block spacing fix #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 30, 2024
Merged

K8s: code block spacing fix #695

merged 11 commits into from
Sep 30, 2024

Conversation

@kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael commented Sep 24, 2024

@kaitlynmichael kaitlynmichael added bug Something isn't working k8s labels Sep 24, 2024
@kaitlynmichael kaitlynmichael requested review from a team and yuvallevy2 September 24, 2024 19:27
@kaitlynmichael kaitlynmichael self-assigned this Sep 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-2151/embeds/k8s-642-redb-admission-webhook-name-change
https://redis.io/docs/staging/DOC-2151/embeds/k8s-admission-webhook-cert
https://redis.io/docs/staging/DOC-2151/operate/kubernetes/active-active/
https://redis.io/docs/staging/DOC-2151/operate/kubernetes/deployment/openshift/openshift-cli
https://redis.io/docs/staging/DOC-2151/operate/kubernetes/deployment/quick-start
https://redis.io/docs/staging/DOC-2151/operate/kubernetes/upgrade/upgrade-redis-cluster

cmilesb
cmilesb requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one note that still has a spacing issue. The rest look okay.

dwdougherty
dwdougherty reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

@kaitlynmichael kaitlynmichael marked this pull request as draft September 25, 2024 15:34
@kaitlynmichael kaitlynmichael marked this pull request as ready for review September 25, 2024 20:07
cmilesb
cmilesb approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kaitlynmichael kaitlynmichael merged commit 2d2cb32 into main Sep 30, 2024
4 checks passed
@kaitlynmichael kaitlynmichael deleted the DOC-2151 branch September 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty left review comments

@cmilesb cmilesb cmilesb approved these changes

@yuvallevy2 yuvallevy2 Awaiting requested review from yuvallevy2

Assignees

@kaitlynmichael kaitlynmichael

Labels

bug Something isn't working k8s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaitlynmichael @dwdougherty @cmilesb